fix(commons/external_dns): use only the crd source, drop unused gateway-httproute#423
Open
davidf-null wants to merge 1 commit into
Open
fix(commons/external_dns): use only the crd source, drop unused gateway-httproute#423davidf-null wants to merge 1 commit into
davidf-null wants to merge 1 commit into
Conversation
…ay-httproute external-dns is configured to consume only the crd source by default. The gateway-httproute source and its associated RBAC (gateway.networking.k8s.io gateways/httproutes) are removed, since they only served that source and no consumer uses it. This reverts the default introduced in #282; the dnsendpoints RBAC is kept because it is the CRD the crd source relies on. - variables.tf: sources default ["crd", "gateway-httproute"] -> ["crd"] - locals.tf: drop the gateway.networking.k8s.io RBAC additionalPermissions - tests: lock in the crd-only default and the absence of gateway RBAC - README.md: update documented default No functional impact: no consumer relies on the gateway-httproute source, so existing deployments are unaffected. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
davidf-null
force-pushed
the
feat/external-dns-crd-source-only
branch
from
5852d91 to
e852136
Compare
davidf-null
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Configures the
commons/external_dnsmodule to use only thecrdsource, removing thegateway-httproutesource and every reference tied to it. This reverts the default introduced in #282.Changes
variables.tf:sourcesdefault["crd", "gateway-httproute"]→["crd"].locals.tf: remove thegateway.networking.k8s.io(gateways/httproutes) RBACadditionalPermissionsblock — it only existed to serve thegateway-httproutesource. Theexternaldns.k8s.io/dnsendpointsRBAC is kept, since that is the CRD thecrdsource reads.tests/external_dns_aws.tftest.hcl: two new runs locking in the new behavior —default_sources_is_crd_onlyandrbac_has_no_gateway_permissions.README.md: documented default updated.Verification
tofu fmt -check -recursive→ cleantofu validate→ Successtofu test→ 48 passed, 0 failed (46 pre-existing + 2 new)gateway/httproutein the module or tests.Impact
No functional impact. No consumer relies on the
gateway-httproutesource, so no existing deployment changes behavior on the next apply.sourcesremains overridable for any future need. Not a breaking change.🤖 Generated with Claude Code